Skip to content

PATCHES.md

Latest commit

 

History

History
62 lines (50 loc) · 3.33 KB

PATCHES.md

File metadata and controls

62 lines (50 loc) · 3.33 KB
Raw

Local patch to ignore 0.4.25

This directory contains the existing locked ignore crate, not a version upgrade. Upstream sources are preserved except for the deltas below in src/dir.rs, src/gitignore.rs and src/walk.rs. The upstream commit's root rustfmt.toml is also included so workspace formatting preserves the vendored source's original style.

Parser delta

resolve_git_commondir reads the first gitfile/commondir line as bytes instead of a UTF-8 String. A small converter preserves native path bytes on Unix and retains UTF-8 validation on other platforms. CRLF handling, error propagation, ignore-source precedence and nested repository behavior are unchanged.

The upstream parser rejects valid Unix metadata paths containing non-UTF-8 bytes. That prevents a synchronized worktree from reaching readiness even after repository identity validation succeeds. Ignoring the error or disabling info/exclude would silently change coverage, so neither is used.

The real-Git shared-daemon regressions cover native gitfiles and independently native commondir files, full CLI/RPC lifecycle, global/info-exclude/gitignore/ dot-ignore precedence, nested repositories, malformed ignore errors, and filesystem-scan parity. The upstream crate tests remain included.

Optional bounded-input hooks

GitignoreBuilder and WalkBuilder accept an optional FileReadControl. The managed caller supplies immutable input snapshots, byte/pattern admission, cancellation/deadline checks and explicit error reporting. The control follows global Git configuration, global/info-exclude/local ignore inputs, native gitfile/commondir reads, nested matchers and serial/parallel walkers. It does not replace the upstream parser, glob matching or precedence rules.

Without a control, the existing file-reading and partial-error behavior stays unchanged. Managed callers record tolerated upstream partial errors and refuse readiness instead of silently searching an incomplete ignore corpus. Their regressions cover cancellation, bounded oversized inputs, nested precedence, configuration changes, native paths and indexed/scan parity. No dependency version or upstream license changed.

Distribution

tgrep-core depends directly on this directory, without a registry-version fallback. This keeps the patch in normal workspace builds, Git/path consumers, the separate fuzz workspace, cargo install --path tgrep-cli --locked, and the repository's checkout-based release/cross-build pipelines. It does not depend on a consumer honoring a workspace-only [patch.crates-io].

This repository distributes binaries and source checkouts, not crates.io packages. Cargo packaging/publishing cannot silently replace the patch with unmodified registry ignore: the path-only dependency causes an explicit missing-version error. Publishing crates would require a deliberately released patched dependency first. Remove this local copy only after an equivalent upstream release passes the same native-path and ignore-precedence regressions.